Skip to content

fix manifest not updating on route creation #5157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 22, 2022
Merged

fix manifest not updating on route creation #5157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
412e6ec
fix glob for ignoring outDir
gtm-nayan Jun 4, 2022
303d9e8
please
gtm-nayan Jun 4, 2022
34c19cf
remove debugging artefact
gtm-nayan Jun 4, 2022
9848624
Break up booleans
gtm-nayan Jun 4, 2022
615c2f2
posixify out_dir before comparison
gtm-nayan Jun 4, 2022
5cb71cc
replace with glob
gtm-nayan Jun 4, 2022
8384c90
extract out dir const
gtm-nayan Jun 4, 2022
3674feb
apparently that doesn't do what I think it did
gtm-nayan Jun 4, 2022
c17e9bd
changeset
gtm-nayan Jun 4, 2022
ecd78aa
shorter glob
gtm-nayan Jun 5, 2022
31c16ae
actually don't need that part either
gtm-nayan Jun 6, 2022
dd020c1
modify test
gtm-nayan Jun 6, 2022
2a96daf
y no yellow lines smh
gtm-nayan Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/young-pens-exist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix manifest not updating when adding routes
5 changes: 4 additions & 1 deletion packages/kit/src/core/dev/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ export const sveltekit = function (svelte_config) {
port: 3000,
strictPort: true,
watch: {
ignored: [`${kit_config.outDir}/**`, `!${kit_config.outDir}/generated/**`]
ignored: [
// Ignore all siblings of config.kit.outDir/generated
`${posixify(kit_config.outDir)}/!(generated)`
]
}
}
},
Expand Down
6 changes: 3 additions & 3 deletions packages/kit/test/apps/basics/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2370,16 +2370,16 @@ test.describe.parallel('Routing', () => {
server.close();
});

test('watch new route in dev', async ({ page, javaScriptEnabled }) => {
test('watch new route in dev', async ({ page }) => {
await page.goto('/routing');

if (!process.env.DEV || javaScriptEnabled) {
if (!process.env.DEV) {
return;
}

// hash the filename so that it won't conflict with
// future test file that has the same name
const route = 'bar' + new Date().valueOf();
const route = 'zzzz' + Date.now();
const content = 'Hello new route';
const __dirname = path.dirname(fileURLToPath(import.meta.url));
const filePath = path.join(__dirname, `../src/routes/routing/${route}.svelte`);
Expand Down