Skip to content

[chore] remove cwd as a method parameter #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2022
Merged

[chore] remove cwd as a method parameter #5040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/kit/src/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,7 @@ prog
async function start(config) {
const { dev } = await import('./core/dev/index.js');

const cwd = process.cwd();

const { address_info, server_config, close } = await dev({
cwd,
port,
host,
https,
Expand All @@ -82,8 +79,7 @@ prog
open: first && (open || !!server_config.open),
base: config.kit.paths.base,
loose: server_config.fs.strict === false,
allow: server_config.fs.allow,
cwd
allow: server_config.fs.allow
});

first = false;
Expand Down
7 changes: 4 additions & 3 deletions packages/kit/src/core/dev/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ import { get_aliases, get_runtime_path } from '../utils.js';
import { create_plugin } from './plugin.js';
import * as sync from '../sync/sync.js';

const cwd = process.cwd();

/**
* @typedef {{
* cwd: string,
* port: number,
* host?: string,
* https: boolean,
Expand All @@ -19,7 +20,7 @@ import * as sync from '../sync/sync.js';
*/

/** @param {Options} opts */
export async function dev({ cwd, port, host, https, config }) {
export async function dev({ port, host, https, config }) {
sync.init(config);

const [vite_config] = deep_merge(
Expand Down Expand Up @@ -71,7 +72,7 @@ export async function dev({ cwd, port, host, https, config }) {
},
configFile: false
}),
await create_plugin(config, cwd)
await create_plugin(config)
],
base: '/'
});
Expand Down
5 changes: 3 additions & 2 deletions packages/kit/src/core/dev/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,13 @@ import { parse_route_id } from '../../utils/routing.js';
// https://github.com/vitejs/vite/blob/3edd1af56e980aef56641a5a51cf2932bb580d41/packages/vite/src/node/plugins/css.ts#L96
const style_pattern = /\.(css|less|sass|scss|styl|stylus|pcss|postcss)$/;

const cwd = process.cwd();

/**
* @param {import('types').ValidatedConfig} config
* @param {string} cwd
* @returns {Promise<import('vite').Plugin>}
*/
export async function create_plugin(config, cwd) {
export async function create_plugin(config) {
const runtime = get_runtime_path(config);

process.env.VITE_SVELTEKIT_APP_VERSION_POLL_INTERVAL = '0';
Expand Down