[fix] resolve fetch requests from the target page #5025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
load'sfetch, it's natural to assume URLs will be resolved relatively to the navigation's target page. Instead, they take the current page into account. This means that, in practice, we must always use absolute or root-relative URLs.This PR resolves URLs relatively to the target page before issuing the native
fetch. It's a simple fix, with just a couple of wrinkles we must pay attention to:Requestobject is mostly read-only, so we need to consume its body and manually copy properties into the new request;Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0