Skip to content

Conversation

@mrkishi
Copy link
Member

@mrkishi mrkishi commented May 22, 2022

When using load's fetch, it's natural to assume URLs will be resolved relatively to the navigation's target page. Instead, they take the current page into account. This means that, in practice, we must always use absolute or root-relative URLs.

This PR resolves URLs relatively to the target page before issuing the native fetch. It's a simple fix, with just a couple of wrinkles we must pay attention to:

  • The Request object is mostly read-only, so we need to consume its body and manually copy properties into the new request;
  • Our ssr-included payloads wouldn't match the full URLs, so we skip normalization during hydration.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2022

🦋 Changeset detected

Latest commit: f5bb10a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit c202a84 into sveltejs:master May 23, 2022
@mrkishi mrkishi deleted the relative-fetch branch May 23, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants