-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix double-mount bug #4891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix double-mount bug #4891
Conversation
🦋 Changeset detectedLatest commit: d402526 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The reason this is failing CI is that changing how the initial page components are loaded has surfaced an unrelated bug: This will hopefully be fixed by vitejs/vite#7644 |
Stumbled upon a nasty bug while investigating #4864 — if you edit
src/routes/a/[b].svelte, then any navigation from/a/1to/a/2will cause[b].svelteto be reloaded (with the HMR cache-busting timestamp), then unmounted and remounted.I think the reason is that we have an
import('/src/routes/[b].svelte')in the HTML and in the routes manifest; the latter import is cachebusted but the one in the HTML isn't.This only occurs during dev.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0