-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add note about ambient dts files to App types #4825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about ambient dts files to App types #4825
Conversation
|
|
Actually this doesn't need a changeset right? |
|
correct, it'd be better to remove the changeset for this one since there's no user-visible change |
|
Weirdly, this isn't affecting the relevant part of the docs: https://kit-svelte-n0jl1ronp-svelte.vercel.app/docs/types#app I don't know if that's some quirk of the process that extracts the types, or some turborepo configuration that is causing that step to be skipped |
This reverts commit 85b47a5.
|
Have removed the changeset - no idea how to use turborepo xD |
|
No idea why these tests are failing, there were no code changes? |
|
Gah, the docs still aren't updating — Turbo is just replaying caches, even though they should be invalid. Will investigate tomorrow |
|
Fixed the screwy turborepo config, the docs are now building correctly 🎉 |
|
thank you! |
|
Glad you got it sorted! xD np |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0Adds a note about how you can't use
importstatements in the app declaration file, closes #3853