Skip to content

Conversation

@ghostdevv
Copy link
Member

@ghostdevv ghostdevv commented May 4, 2022

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Adds a note about how you can't use import statements in the app declaration file, closes #3853

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2022

⚠️ No Changeset found

Latest commit: 581ed5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ghostdevv
Copy link
Member Author

Actually this doesn't need a changeset right?

@benmccann
Copy link
Member

correct, it'd be better to remove the changeset for this one since there's no user-visible change

@benmccann benmccann added documentation Improvements or additions to documentation types / typescript labels May 5, 2022
@Rich-Harris
Copy link
Member

Weirdly, this isn't affecting the relevant part of the docs: https://kit-svelte-n0jl1ronp-svelte.vercel.app/docs/types#app

I don't know if that's some quirk of the process that extracts the types, or some turborepo configuration that is causing that step to be skipped

This reverts commit 85b47a5.
@ghostdevv
Copy link
Member Author

Have removed the changeset - no idea how to use turborepo xD

@ghostdevv
Copy link
Member Author

ghostdevv commented May 12, 2022

No idea why these tests are failing, there were no code changes?

@Rich-Harris
Copy link
Member

Gah, the docs still aren't updating — Turbo is just replaying caches, even though they should be invalid. Will investigate tomorrow

@Rich-Harris
Copy link
Member

Fixed the screwy turborepo config, the docs are now building correctly 🎉

@Rich-Harris Rich-Harris merged commit 32a000f into sveltejs:master May 17, 2022
@Rich-Harris
Copy link
Member

thank you!

@ghostdevv
Copy link
Member Author

Glad you got it sorted! xD np

@ghostdevv ghostdevv deleted the update-apptype-document branch May 17, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation types / typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using a import type statement in app.d.ts breaks

4 participants