Skip to content

Conversation

@baseballyama
Copy link
Member

Follow up: #4235

The latest release was failed due to some build configuration.
So I tried to fix it.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2022

⚠️ No Changeset found

Latest commit: 06b9723

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pnpm-lock.yaml Outdated
specifiers:
'@sveltejs/adapter-auto': workspace:*
'@sveltejs/adapter-static': workspace:^1.0.0-next.28
'@sveltejs/adapter-static': workspace:^1.0.0-next.29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The static adapter should presumably be completely removed from the kt.svelte.dev site.

Copy link
Member Author

@baseballyama baseballyama Mar 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's just happened on my local, but after removing @sveltejs/adapter-static, pnpm build is failed.
But the deployment to Vercel appears successful.

@PH4NTOMiki
Copy link
Contributor

Can you try to merge it @Conduitry

@benmccann
Copy link
Member

Is every project going to need devalue? I don't think that would be a good situation

I'm guessing the need for it might be related to this: #3942 (comment)

@Conduitry
Copy link
Member

@benmccann devalue is only needed, I believe, because of the changes in ab4ef9c - I wouldn't say no to reverting those as well, because it's clearly not the proper solution. (I'm not even sure whether Rich intended that to be part of the final PR.)

@Rich-Harris
Copy link
Member

It would be nice to get rid of devalue if we can, so this problem doesn't pop up. The rationale behind ab4ef9c was to make it easier to debug Kit while working on kit.svelte.dev, and I do think there's some value in preserving that — definitely wouldn't be upset if we decided against it but for now I reckon I'll merge this so that things are at least working again

@Rich-Harris Rich-Harris merged commit 242a5f2 into sveltejs:master Mar 5, 2022
@PH4NTOMiki
Copy link
Contributor

@Rich-Harris thanks for merging that

@PH4NTOMiki
Copy link
Contributor

@Rich-Harris I think you need to rerun that action that failed previously.
not sure thought

@baseballyama
Copy link
Member Author

Maybe should we swap (rebase) latest 2 commits for releasing?

@baseballyama baseballyama mentioned this pull request Mar 6, 2022
5 tasks
baseballyama added a commit to baseballyama/kit that referenced this pull request Mar 6, 2022
sveltejs#4011 added @sveltejs/adapter-static .
But sveltejs#4239 removed it.
Then deploy process is failed. (Please see sveltejs#4244 (comment) for more details)
@bitdom8
Copy link

bitdom8 commented Mar 6, 2022

Latest build doesn't run

pnpm run build

ReferenceError: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and 'C:\Users\Administrator\Documents\client\package.json' contains "type": "module". To treat
it as a CommonJS script, rename it to use the '.cjs' file extension.

Rich-Harris pushed a commit that referenced this pull request Mar 6, 2022
* add @sveltejs/adapter-static.

#4011 added @sveltejs/adapter-static .
But #4239 removed it.
Then deploy process is failed. (Please see #4244 (comment) for more details)

* workspace:^1.0.0-next.29 -> workspace:*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants