Skip to content

Deduplicate CI testing #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 4, 2022
Merged

Deduplicate CI testing #4206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4b0839a
deduplicate tests
mrkishi Mar 4, 2022
ac5a13d
Merge branch 'master' into ci-testing
Rich-Harris Mar 4, 2022
fdb4fde
Update packages/kit/package.json
Rich-Harris Mar 4, 2022
ac30799
Merge branch 'ci-testing' of github.com:mrkishi/kit into ci-testing
Rich-Harris Mar 4, 2022
3258c13
Merge branch 'master' into ci-testing
Rich-Harris Mar 4, 2022
470b4fb
parallelize tests
mrkishi Mar 3, 2022
0da1989
test if splitting basics helps any
mrkishi Mar 4, 2022
3877089
Revert "parallelize tests"
mrkishi Mar 4, 2022
14670dd
reduce number of test scripts
mrkishi Mar 4, 2022
a0333d7
increase playwright workers on ci
mrkishi Mar 4, 2022
8c4f698
reduce script further
mrkishi Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 4 additions & 18 deletions packages/kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,30 +60,16 @@
"build": "rollup -c && node scripts/cp.js src/runtime/components assets/components && npm run types",
"dev": "rollup -cw",
"lint": "eslint --ignore-path .gitignore --ignore-pattern \"src/packaging/test/**\" \"{src,test}/**/*.{ts,mjs,js,svelte}\" && npm run check-format",
"check": "tsc && npm run check:integration && npm run check:prerendering",
"check:integration": "npm run check:integration:amp && npm run check:integration:basics && npm run check:integration:options && npm run check:integration:options-2",
"check:integration:amp": "cd test/apps/amp && pnpm sync && pnpm check",
"check:integration:basics": "cd test/apps/basics && pnpm sync && pnpm check",
"check:integration:options": "cd test/apps/options && pnpm sync && pnpm check",
"check:integration:options-2": "cd test/apps/options-2 && pnpm sync && pnpm check",
"check:prerendering": "npm run check:prerendering:basics && npm run check:prerendering:options",
"check:prerendering:basics": "cd test/prerendering/basics && pnpm sync && pnpm check",
"check:prerendering:options": "cd test/prerendering/options && pnpm sync && pnpm check",
"check": "tsc",
"check:all": "tsc && pnpm run -r check --filter ./",
"format": "npm run check-format -- --write",
"check-format": "prettier --check . --config ../../.prettierrc --ignore-path .gitignore",
"prepublishOnly": "npm run build",
"test": "npm run test:unit && npm run test:typings && npm run test:packaging && npm run test:prerendering && npm run test:integration",
"test": "npm run test:unit && npm run test:typings && npm run test:packaging",
"test:all": "pnpm run -r test --workspace-concurrency 1 --filter ./",
"test:unit": "uvu src \"(spec\\.js|test[\\\\/]index\\.js)\" -i packaging",
"test:typings": "tsc --project test/typings",
"test:prerendering": "pnpm test:prerendering:basics && pnpm test:prerendering:options",
"test:prerendering:basics": "cd test/prerendering/basics && pnpm test",
"test:prerendering:options": "cd test/prerendering/options && pnpm test",
"test:packaging": "uvu src/packaging \"(spec\\.js|test[\\\\/]index\\.js)\"",
"test:integration": "pnpm test:integration:amp && pnpm test:integration:basics && pnpm test:integration:options && pnpm test:integration:options-2",
"test:integration:amp": "cd test/apps/amp && pnpm test",
"test:integration:basics": "cd test/apps/basics && pnpm test",
"test:integration:options": "cd test/apps/options && pnpm test",
"test:integration:options-2": "cd test/apps/options-2 && pnpm test",
"types": "node scripts/extract-types.js"
},
"exports": {
Expand Down
3 changes: 2 additions & 1 deletion packages/kit/test/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ export const config = {
use: {
screenshot: 'only-on-failure',
trace: 'retain-on-failure'
}
},
workers: process.env.CI ? 2 : undefined
Copy link
Member

@benmccann benmccann Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had removed this purposefully not long ago. a lot of the CIs have only 1 CPU and we were worried that having multiple workers was making them compete for CPU and causing timeouts

Copy link
Member Author

@mrkishi mrkishi Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test, but adding full parallelization to the tests (at the pnpm level) didn't cause contention to the point of increasing run time, in fact it reduced a few percent. This is also a "max workers" setting—shouldn't playwright still use 1 worker when there's only one cpu?

Copy link
Member

@benmccann benmccann Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think adding more workers would increase overall runtime, but it may make individual tests take longer to run

But anyway it looks like I may have been wrong that some environments only support a single CPU? I think I'm seeing now that most support 2, so this would be fine

};

/**
Expand Down