-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix Clashing endpoint-powered pages break route sorting(#4038) #4139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Rich-Harris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you — I left comments inline. This PR will need some tests before we can merge it!
Co-authored-by: Rich Harris <[email protected]>
Rich-Harris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, but this will still need tests before it can be properly reviewed or merged
|
Can you undo the |
|
Thank you. I spent some time looking into this PR — unfortunately |
I agree width you, less sophisticated is better. |
issue #4038
fix:
shadowof shadowed page not change after merge matching page/endpoint pairsupdate:
0e123e6There are multiple fallthrough shadow page , like this:
[a] -- fallthrough -> [b] --fallthrough --> [c]Before you need to request three times from client-side,
now you just need send one request.
update:
7397a20add test :
Not in this Pr
update:
a4a59f9~d12479ecmerge from master
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0