[chore] refactor AMP validation #3554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 032c916 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 032c916 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61f2c596e161710007ab990e |
Rich-Harris
requested changes
Jan 26, 2022
Member
Rich-Harris
left a comment
Rich-Harris
left a comment
There was a problem hiding this comment.
it might be worth adding a test for this somehow?
Member
Author
|
We do have amp tests already in |
Rich-Harris
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the AMP validation happen in a
handlehook. This should fix #3330 (it won't allow disabling it, but it will make it so that it's correct) and be a step towards #2603. It wouldn't be hard to move this to an external package for users to call. However, the actual AMP HTML generation is pretty tied into SvelteKit and I'm not sure how we'd change that