Skip to content

Conversation

@paoloricciuti
Copy link
Member

Since we now fork every time, we should wait on the commit promise rather than settled (there are technically a couple of svelte versions where settled is there and works but not fork so maybe we could also wait for settled concurrently, but I'd say it's probably overkill).

Without this, #14800 is basically non-useful since settled resolves immediately if we invoke it after awaiting load_cache_fork😅

P.s. for some reason running the test locally I see a bunch of failing tests...but that's also true before the change so 🤷🏼

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

🦋 Changeset detected

Latest commit: 346dce8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paoloricciuti paoloricciuti merged commit 102aecf into main Oct 27, 2025
22 checks passed
@paoloricciuti paoloricciuti deleted the wait-for-commit-promise branch October 27, 2025 08:13
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants