Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fluffy-lights-know.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: `form.fields.set()` triggers `form.fields.value()` updates
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,15 @@ export function form(id) {
} else {
input = deep_set(input, path.map(String), value);
}

const copy = path.slice();

do {
const name = build_path_string(copy);

versions[name] ??= 0;
versions[name] += 1;
} while (copy.pop() !== undefined);
},
() => issues
)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<script>
import { values } from './value.remote.js';
</script>

<h1>Remote Form Set Test</h1>

<form {...values}>
<label>
Leaf:
<input {...values.fields.leaf.as('text')} />
</label>

<button>Submit</button>
</form>

<h2>Full Form Value</h2>
<pre id="full-value">{JSON.stringify(values.fields.value(), null, ' ')}</pre>

<button id="update-value" onclick={() => values.fields.leaf.set('new value')}>Update Value</button>
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { form } from '$app/server';
import * as v from 'valibot';

export const values = form(
v.object({
leaf: v.string()
}),
async (data) => {
return { success: true, data };
}
);
20 changes: 20 additions & 0 deletions packages/kit/test/apps/basics/test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1982,6 +1982,26 @@ test.describe('remote functions', () => {
expect(JSON.parse(arrayValue)).toEqual([{ leaf: 'array-0-leaf' }, { leaf: 'array-1-leaf' }]);
});

test('form.fields.set() triggers form.fields.value() updates', async ({
page,
javaScriptEnabled
}) => {
if (!javaScriptEnabled) return;

await page.goto('/remote/form/set');

const before = await page.locator('#full-value').textContent();
expect(JSON.parse(before)).toEqual({});

await page.locator('#update-value').click();

const leafValue = await page.locator('input[name="leaf"]').inputValue();
expect(leafValue).toBe('new value');

const after = await page.locator('#full-value').textContent();
expect(JSON.parse(after)).toEqual({ leaf: 'new value' });
});

test('selects are not nuked when unrelated controls change', async ({
page,
javaScriptEnabled
Expand Down
Loading