Skip to content

Conversation

@PatrickG
Copy link
Member

@PatrickG PatrickG commented Oct 8, 2025

Fixes #14618

If svelte experimental async is enabled we need to wait a microtask(?) between mounting the app and running the after_navigate_callbacks, otherwise the script blocks run after running the after_navigate_callbacks (which means there are no callbacks yet).

I'm not sure if adding a new test app is the right choice. Maybe we should run all tests once with and once without experimental async instead?


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2025

🦋 Changeset detected

Latest commit: 8533df0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@hyunbinseo
Copy link
Contributor

If this takes time, could there be a release where SvelteKit warns about using async and afterNavigate together?

It seems to be a better approach then documenting in the Svelte docs.

I have a private library that relies heavily on afterNavigate and it took me quite some time to debug and find this issue.

@korywka
Copy link

korywka commented Oct 28, 2025

confirm. if it takes time to merge, please note this bug in remote functions docs or at afterNavigate section as expected. you will save a lot of time for others people for debugging 🙏

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the new test suite in favor of running the basic test suite with async mode. I confirmed that a test would fail without this fix; there's another test that fails but that's unrelated to this PR so 👍

@dummdidumm dummdidumm merged commit 53b1b73 into sveltejs:main Oct 28, 2025
21 checks passed
@github-actions github-actions bot mentioned this pull request Oct 28, 2025
@teemingc teemingc mentioned this pull request Oct 30, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async mode prevents afterNavigate from running at mount

6 participants