-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: afterNavigate callback not running after hydration when experimental async is enabled
#14644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8533df0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
If this takes time, could there be a release where SvelteKit warns about using It seems to be a better approach then documenting in the Svelte docs. I have a private library that relies heavily on |
|
confirm. if it takes time to merge, please note this bug in remote functions docs or at |
dummdidumm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the new test suite in favor of running the basic test suite with async mode. I confirmed that a test would fail without this fix; there's another test that fails but that's unrelated to this PR so 👍
Fixes #14618
If svelte experimental async is enabled we need to wait a microtask(?) between mounting the app and running the
after_navigate_callbacks, otherwise the script blocks run after running theafter_navigate_callbacks(which means there are no callbacks yet).I'm not sure if adding a new test app is the right choice. Maybe we should run all tests once with and once without experimental async instead?
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits