Skip to content

Conversation

@danieldiekmeier
Copy link
Contributor

@danieldiekmeier danieldiekmeier commented Sep 20, 2025

In #14195, the access of __SVELTEKIT_PAYLOAD__.data had been fixed like this:

export const remote_responses = __SVELTEKIT_PAYLOAD__?.data ?? {};

However, #14435 introduced a change (looks like a typo) where the ? moved to the wrong spot:

if (__SVELTEKIT_PAYLOAD__.data) {
	remote_responses = __SVELTEKIT_PAYLOAD__?.data;
}

This brought back the earlier problem in some of my apps. This PR moves the ? out into the condition.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2025

🦋 Changeset detected

Latest commit: 2e75439

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danieldiekmeier danieldiekmeier changed the title Fix __SVELTEKIT_PAYLOAD__.data access again fix: Fix __SVELTEKIT_PAYLOAD__.data access again Sep 20, 2025
@danieldiekmeier danieldiekmeier changed the title fix: Fix __SVELTEKIT_PAYLOAD__.data access again fix: ensure __SVELTEKIT_PAYLOAD__.data access is safe Sep 20, 2025
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

'@sveltejs/kit': patch
---

ensure `__SVELTEKIT_PAYLOAD__.data` access is safe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ensure `__SVELTEKIT_PAYLOAD__.data` access is safe
fix: ensure `__SVELTEKIT_PAYLOAD__.data` access is safe

@dummdidumm dummdidumm merged commit fbad6a0 into sveltejs:main Sep 21, 2025
19 checks passed
@github-actions github-actions bot mentioned this pull request Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants