Skip to content

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Sep 18, 2025

fixes #14347

This PR reverts the fix from #14219 which caused the init hook to run even if there's nothing to prerender. Instead of running the init hook early, we just set the env variables when looking for prerendered remote functions. This avoids any errors for missing env variables when evaluating the user's remote function modules. We only run the init hook once we've found things we need to prerender.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2025

🦋 Changeset detected

Latest commit: f58e1f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc teemingc changed the title fix fix: avoid running init hook when there's nothing to prerender Sep 18, 2025
@teemingc teemingc changed the title fix: avoid running init hook when there's nothing to prerender fix: avoid running init hook during builds when there's nothing to prerender Sep 18, 2025
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice solution 👍

@dummdidumm dummdidumm merged commit fae6b5a into main Sep 18, 2025
22 checks passed
@dummdidumm dummdidumm deleted the fix-init-without-prerender branch September 18, 2025 15:46
@github-actions github-actions bot mentioned this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

while build newer SvelteKit runs the init: ServerInit function from hooks.server.ts

3 participants