fix: defer transport decoding until app is loaded #14428
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14423
Remote functions with custom transport encoders were failing with "app is not defined" error when called at module level during SSR. The issue occurred because the generated HTML tried to call app.decode() before the app module was loaded.
This fix defers the decoding by storing encoded data in a __deferred array and using placeholder objects {__deferredIndex: n} in the data. After the app module loads, a processDeferred function recursively replaces all placeholders with the actual decoded values. The solution works across all boot paths and includes error handling for decode failures.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits