Skip to content

Conversation

@LeeWxx
Copy link
Contributor

@LeeWxx LeeWxx commented Sep 14, 2025

Fixes #14423

Remote functions with custom transport encoders were failing with "app is not defined" error when called at module level during SSR. The issue occurred because the generated HTML tried to call app.decode() before the app module was loaded.

This fix defers the decoding by storing encoded data in a __deferred array and using placeholder objects {__deferredIndex: n} in the data. After the app module loads, a processDeferred function recursively replaces all placeholders with the actual decoded values. The solution works across all boot paths and includes error handling for decode failures.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2025

🦋 Changeset detected

Latest commit: 0462552

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@LeeWxx LeeWxx marked this pull request as draft September 14, 2025 16:13
@LeeWxx LeeWxx marked this pull request as ready for review September 14, 2025 17:29
@dummdidumm
Copy link
Member

Thank you, but this doesn't look quite right. I opened a simpler fix, therefore closing in favor of #14434

@LeeWxx
Copy link
Contributor Author

LeeWxx commented Sep 16, 2025

@dummdidumm Understood, glad there’s a simpler fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streaming data from remote functions that relies on custom transport regression

2 participants