Skip to content

Conversation

@Conduitry
Copy link
Member

Fixes #14218, hopefully. This simply reverts the change from ??s to ||s. The values here being empty strings might indicate the environment variable not being set (in which case we definitely want to fall back to the default values) or it might indicate the env var being set and the header being set but to an empty value (in which case, it would be more helpful to also fall back to the default values). Using ?? over || is generally a worthwhile endeavor for more strict correctness, but not in this case.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2025

🦋 Changeset detected

Latest commit: b462f37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 4f01f04 into sveltejs:main Aug 14, 2025
18 checks passed
@github-actions github-actions bot mentioned this pull request Aug 14, 2025
@Conduitry Conduitry deleted the gh-14218 branch August 14, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad Request Errors After Upgrading to @sveltejs/[email protected] and @sveltejs/[email protected]

2 participants