Skip to content

fix: load env before prerender #14219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 19, 2025
Merged

fix: load env before prerender #14219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ebe2bd2
fix: load env before prerender
paoloricciuti Aug 14, 2025
8237116
chore: changeset
paoloricciuti Aug 14, 2025
0bb7db9
chore: add test
paoloricciuti Aug 14, 2025
6bd6e0b
chore: add comment in test file
paoloricciuti Aug 15, 2025
b436297
Merge branch 'main' into load-env-before-prerender
Rich-Harris Aug 19, 2025
b2d1de4
simplify
Rich-Harris Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wide-cobras-yell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: load env before prerender
12 changes: 6 additions & 6 deletions packages/kit/src/core/postbuild/prerender.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ async function prerender({ hash, out, manifest_path, metadata, verbose, env }) {

installPolyfills();

const server = new Server(manifest);
await server.init({
env,
read: (file) => createReadableStream(`${config.outDir}/output/server/${file}`)
});

/** @type {Map<string, string>} */
const saved = new Map();

Expand Down Expand Up @@ -503,12 +509,6 @@ async function prerender({ hash, out, manifest_path, metadata, verbose, env }) {

log.info('Prerendering');

const server = new Server(manifest);
await server.init({
env,
read: (file) => createReadableStream(`${config.outDir}/output/server/${file}`)
});

for (const entry of config.prerender.entries) {
if (entry === '*') {
for (const [id, prerender] of prerender_map) {
Expand Down
8 changes: 8 additions & 0 deletions packages/kit/test/apps/basics/src/routes/remote/accessing-env.remote.js
View file
Open in desktop
Copy link
Member

@teemingc teemingc Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The presence of this file alone is the test for if this works or not, right? Can we add a comment to this file explaining that if that’s the case?

Copy link
Member

@Rich-Harris Rich-Harris Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/sveltejs/kit/pull/14219/files#r2278077682

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { env } from '$env/dynamic/private';
import { env as public_env } from '$env/dynamic/public';

if (!env.PRIVATE_DYNAMIC || !public_env.PUBLIC_DYNAMIC) {
// This checks that dynamic env vars are available when prerendering remote functions
// https://github.com/sveltejs/kit/pull/14219
throw new Error('Dynamic environment variables are not set up correctly');
}
Loading