-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: extend Svelte Config type #13982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 3b26193 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Just to double-check, these types exist in the correct way since the vps version that we have a peer dep on, right? |
Yes. I tested this by installing this PR into a new SvelteKit project. One thing to think about is how to link to the VPS config type and let people know it's based on their VPS version in https://svelte-dev-git-preview-kit-13982-svelte.vercel.app/docs/kit/configuration#Config . Should we explain it in the kit/documentation/docs/98-reference/50-configuration.md Lines 29 to 31 in 537d33e
|
|
SvelteConfig is exported by v-p-s@3 which is the lowest version sveltekit supports. |
|
looks like it works, setting up an old kit project via i had to install |

This PR changes our Config type to extend the VPS Config type instead of trying to duplicate it like we are now.
TODO:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits