-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: regression with rolldown-vite and single JS bundle apps
#13941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5318c87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I'm a little hesitant about this as I'm not sure what effect removing |
Re rolldown/rolldown#5161 (comment) |
|
Just a note for myself: rolldown/rolldown#5161 (comment) suggested to use |
Co-authored-by: Ben McCann <[email protected]>
5318c87 to
84d4eb9
Compare
reverts #13915
This PR replacesmanualChunkswithinlineDynamicImportsfor bundling a single JS file (for 'single' and 'inline' apps) sincemanualChunksdoes not work when used with Rolldown (it's also a deprecated option). Luckily,inlineDynamicImports: trueworks in both Rollup and Rolldown for creating a single JS file.Also bumps the VPS version for dev deps and resolves a todo
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits