Skip to content

Conversation

@teemingc
Copy link
Member

This PR gets rid of all the red lines in our Playwright tests. It also updates the Playwright utils type definitions for our SvelteKit helpers which got out of date at some point.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2025

⚠️ No Changeset found

Latest commit: 6566311

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@dummdidumm dummdidumm merged commit abcb7c0 into main Jun 20, 2025
18 checks passed
@dummdidumm dummdidumm deleted the fix-playwright-typescript branch June 20, 2025 10:38
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jun 21, 2025
* main:
  bye bye red lines (sveltejs#13911)
  docs: mention support for vite 7 as well
  docs: mention that rolldown is experimental
  docs: expand changelog entry
  Version Packages (sveltejs#13908)
  feat: support Rolldown (sveltejs#13747)
  chore: Correct transport docs (sveltejs#13893)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants