-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: add getRequestEvent to $app/server
#13582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
36698ae
feat: add `getRequestEvent` to `$app/server`
Rich-Harris 66b8190
reduce indentation
Rich-Harris b37f331
innocuous change to try and trigger a docs preview
Rich-Harris 931ab21
regenerate
Rich-Harris f2053c1
more detailed error message
Rich-Harris 6fc3941
tighten up
Rich-Harris ede1a56
innocuous change to try and trigger a docs preview
Rich-Harris 0b85cb9
innocuous change to try and trigger a docs preview
Rich-Harris 7c541c1
innocuous change to try and trigger a docs preview
Rich-Harris 62648f5
Update packages/kit/test/apps/basics/src/routes/get-request-event/end…
Rich-Harris 98dcd90
add since tag
Rich-Harris aceec46
Merge branch 'get-request-event' of github.com:sveltejs/kit into get-…
Rich-Harris 52f2103
Merge branch 'main' into get-request-event
Rich-Harris ddc2381
add some docs
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@sveltejs/kit': minor | ||
| --- | ||
|
|
||
| feat: add `getRequestEvent` to `$app/server` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /** @import { RequestEvent } from '@sveltejs/kit' */ | ||
|
|
||
| /** @type {RequestEvent | null} */ | ||
| let request_event = null; | ||
|
|
||
| /** @type {import('node:async_hooks').AsyncLocalStorage<RequestEvent | null>} */ | ||
| let als; | ||
|
|
||
| try { | ||
| const hooks = await import('node:async_hooks'); | ||
| als = new hooks.AsyncLocalStorage(); | ||
| } catch { | ||
| // can't use AsyncLocalStorage, but can still call getRequestEvent synchronously. | ||
| // this isn't behind `supports` because it's basically just StackBlitz (i.e. | ||
| // in-browser usage) that doesn't support it AFAICT | ||
| } | ||
|
|
||
| /** | ||
| * Returns the current `RequestEvent`. Can be used inside `handle`, `load` and actions (and functions called by them). | ||
| * | ||
| * In environments without [`AsyncLocalStorage`](https://nodejs.org/api/async_context.html#class-asynclocalstorage), this must be called synchronously (i.e. not after an `await`). | ||
| * @since 2.20.0 | ||
| */ | ||
| export function getRequestEvent() { | ||
| const event = request_event ?? als?.getStore(); | ||
|
|
||
| if (!event) { | ||
| let message = | ||
| 'Can only read the current request event inside functions invoked during `handle`, such as server `load` functions, actions, and server endpoints.'; | ||
|
|
||
| if (!als) { | ||
| message += | ||
| ' In environments without `AsyncLocalStorage`, the event must be read synchronously, not after an `await`.'; | ||
| } | ||
|
|
||
| throw new Error(message); | ||
| } | ||
|
|
||
| return event; | ||
| } | ||
|
|
||
| /** | ||
| * @template T | ||
| * @param {RequestEvent | null} event | ||
| * @param {() => T} fn | ||
| */ | ||
| export function with_event(event, fn) { | ||
| try { | ||
| request_event = event; | ||
| return als ? als.run(event, fn) : fn(); | ||
| } finally { | ||
| request_event = null; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do users see on StackBlitz? Will it be the
Can only read the current request event when the event is being processedmessage? That might be confusing if so and perhaps it's better to throw a different error hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upgraded the message to include a mention of ALS, if it's absent