Skip to content

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Mar 3, 2025

fixes #13503

This PR includes the assets imported through Vite in universal load function files as server assets so that when the universal load function tries to fetch the URL of the imported asset, the file can be read on the server instead of returning a 404 not found text response.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2025

🦋 Changeset detected

Latest commit: 3233cf2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved it but haven't merged it just so you can add those periods before merging 😆 Feel free to merge when you're ready

@teemingc
Copy link
Member Author

teemingc commented Mar 4, 2025

Thanks! 😆

@teemingc teemingc merged commit f9458e3 into main Mar 4, 2025
14 of 15 checks passed
@teemingc teemingc deleted the fix-universal-load-server-asset branch March 4, 2025 06:52
@github-actions github-actions bot mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fetch errors from import.meta.glob paths in preview

3 participants