Skip to content

fix: avoid file import that is incompatible with Windows #13495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 24, 2025
Merged

fix: avoid file import that is incompatible with Windows #13495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b5c275
fix: avoid file import that is incompatible with Windows
Aldthony Feb 23, 2025
dafc0ae
add changeset
Aldthony Feb 23, 2025
d52279b
Update packages/adapter-netlify/index.js
teemingc Feb 24, 2025
85389e2
Update .changeset/eight-walls-melt.md
teemingc Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eight-walls-melt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/adapter-netlify': patch
---

fix: correctly import manifest on Windows machines
3 changes: 2 additions & 1 deletion packages/adapter-netlify/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ async function generate_edge_functions({ builder }) {
writeFileSync(`${tmp}/manifest.js`, `export const manifest = ${manifest};\n`);

/** @type {{ assets: Set<string> }} */
const { assets } = (await import(`${tmp}/manifest.js`)).manifest;
// we have to prepend the file:// protocol because Windows doesn't support absolute path imports
const { assets } = (await import(`file://${tmp}/manifest.js`)).manifest;

const path = '/*';
// We only need to specify paths without the trailing slash because
Expand Down
Loading