Skip to content

Conversation

@Black1358
Copy link
Contributor

@Black1358 Black1358 commented Jan 20, 2025

This PR refines the alias resolution process to correctly handle import and export statements. Previously, alias replacement was applied too broadly, affecting non-import strings. Now, the RegExps specifically target import/export statements.

Prevents accidental replacements of non-import strings that resemble imports (e.g., const text = "from 'alias'").


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: 5bd67d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/package Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dummdidumm dummdidumm merged commit 2ca09ce into sveltejs:main Jan 20, 2025
13 checks passed
@github-actions github-actions bot mentioned this pull request Jan 20, 2025
dummdidumm added a commit that referenced this pull request Sep 11, 2025
The fix in #13351 solved some issues but introduced others. This reworks the aliasing further to better check against the patterns that come up.

Fixes #13532
Fixes #13436
@dummdidumm dummdidumm mentioned this pull request Sep 11, 2025
5 tasks
Rich-Harris pushed a commit that referenced this pull request Sep 12, 2025
* fix: better alias resolution

The fix in #13351 solved some issues but introduced others. This reworks the aliasing further to better check against the patterns that come up.

Fixes #13532
Fixes #13436

* shut eslint, please?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants