Skip to content

fix: do not replace headers on fetch requests with error state #13341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 21, 2025
Merged

fix: do not replace headers on fetch requests with error state #13341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf249c0
Do not replace headers on fetch requests with error state
aureleoules Jan 18, 2025
9802a74
avoid modifying original request
teemingc Jan 20, 2025
e7d6bc6
changeset
teemingc Jan 20, 2025
c216006
Update packages/kit/src/runtime/server/respond.js
dummdidumm Jan 21, 2025
85bef81
Update packages/kit/src/runtime/server/respond.js
dummdidumm Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bright-scissors-grow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: avoid overwriting headers for sub-requests made while loading the error page
10 changes: 5 additions & 5 deletions packages/kit/src/runtime/server/respond.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,11 +508,11 @@ export async function respond(request, options, manifest, state) {
}

if (state.error && event.isSubRequest) {
return await fetch(request, {
headers: {
'x-sveltekit-error': 'true'
}
});
// avoid overwriting the headers. This could be a same origin fetch request
// to an external service from the root layout while rendering an error page
const headers = new Headers(request.headers);
headers.set('x-sveltekit-error', 'true');
return await fetch(request, { headers });
}

if (state.error) {
Expand Down
Loading