Skip to content

Conversation

@hyunbinseo
Copy link
Contributor

- Listening on 0.0.0.0:3000
+ Listening on http://0.0.0.0:3000

Allows the listening on address to be clickable on the VS Code terminal.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 9a0f905

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13146-svelte.vercel.app/

this is an automated message

@teemingc
Copy link
Member

Thank you!

@teemingc teemingc merged commit 8749894 into sveltejs:main Dec 12, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
@hyunbinseo hyunbinseo deleted the patch-3 branch December 13, 2024 09:58
@teemingc
Copy link
Member

@Conduitry sorry, I wasn't aware about your comment on this and missed it #11966 (comment)
Should we revert this change?

@hyunbinseo
Copy link
Contributor Author

Doesn't the adapter-node build listen to http://${host}:${port} regardless of the reverse proxy?

@teemingc
Copy link
Member

Yeah, perhaps I misunderstood the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants