Skip to content

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Dec 4, 2024

fixes #12065

Instead of spreading the imported functions from the server hooks file and universal hooks file, this PR changes it to specifically import and return each hook. This prevents similarly named hooks exported from hook.js from overwriting hooks from hook.server.js


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@teemingc teemingc changed the title fix: prevent hooks exported from hooks.js from overwriting hooks in hooks.server.js fix: prevent hooks exported from hooks.js from overwriting hooks from hooks.server.js Dec 4, 2024
@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: ada0065

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 85b5716 into main Dec 10, 2024
14 checks passed
@Rich-Harris Rich-Harris deleted the fix-hooks-import branch December 10, 2024 14:21
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
@tkhs0813
Copy link
Contributor

@Rich-Harris @eltigerchino
We were able to use reroute in hooks.server.js, but as a result of this change, it is no longer usable, and we are confused.
Is it correct to say that reroute should only be usable in hooks.js?

@teemingc
Copy link
Member Author

@Rich-Harris @eltigerchino We were able to use reroute in hooks.server.js, but as a result of this change, it is no longer usable, and we are confused. Is it correct to say that reroute should only be usable in hooks.js?

Yes, reroute is a universal hook and belongs in the universal hooks file hooks.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handle hook runs in hooks.js

4 participants