Skip to content

Conversation

@marekdedic
Copy link

@marekdedic marekdedic commented Oct 31, 2024

This PR fixes #12920.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2024

🦋 Changeset detected

Latest commit: 4fce1f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/enhanced-img Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marekdedic
Copy link
Author

Hmm, one of the tests fails but I don't see any clear error message... Any help here?

@benmccann
Copy link
Member

#12822 would probably also fix this by moving off of estree-walker

@benmccann
Copy link
Member

thanks for this!

will close it though as I merged #12822

@benmccann benmccann closed this Nov 1, 2024
@marekdedic marekdedic deleted the enhanced-img-estree-walker-dep branch November 2, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[enhanced-img] Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'estree-walker'

2 participants