Skip to content

Conversation

@potch
Copy link
Contributor

@potch potch commented Apr 16, 2024

Allow app.html to interpolate the version string passed to kit.version.name in svelte.config.js. This makes it easier for static <head> includes for third-party scripts to be passed the current app version, e.g.

<script>
  GenericAnalytics.init({
    token: "abc123",
    application: "web",
    version: "%sveltekit.version%",
  });
</script>

This is nice ergonomic improvement, but there are several available workarounds:

  • set a variable using a globally included %sveltekit.head%
  • duplicate the version string to an env variable and use %sveltekit.env.PUBLIC_VERSION%
  • do your own pre-templating of app.html in hooks.server

This PR resolves #12130.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: eda91c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc teemingc changed the title Add %sveltekit.version% placeholder for template interpolation feat: add %sveltekit.version% placeholder for template interpolation May 16, 2024
@teemingc teemingc added the feature / enhancement New feature or request label May 16, 2024
@benmccann
Copy link
Member

If we did do this it would need to be added to the documentation. I'm not sure if needs to be in the playground though

The main question I have is whether we should add this vs having folks use the layout: #12130 (comment)

@teemingc teemingc added the needs-decision Not sure if we want to do this yet, also design work needed label Oct 28, 2024
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Rich-Harris Rich-Harris force-pushed the potch/add-sveltekit-version-placeholder branch from 00434aa to eda91c8 Compare September 15, 2025 23:21
@Rich-Harris Rich-Harris merged commit ff8a85e into sveltejs:main Sep 16, 2025
35 of 36 checks passed
@github-actions github-actions bot mentioned this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature / enhancement New feature or request needs-decision Not sure if we want to do this yet, also design work needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a %svelte.version% template placeholder to propagate the current kit.version.name to app.html

4 participants