fix: popstate navigation wasn't cancelling ongoing navigation() calls when landing on the same page
#10727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10512
Maybe also this? #10700
Bug description
When navigating with
popstate, there is an early return if only#part of the url changed.This ignores the edgecase where quick navigation ends on the same page, e.g.
A->B->AIn this case:
popstatetoBcallsnavigate()popstateback toAreturns early doing nothingnavigate()starts renderingBrendered, butAin the address barProposed fix
popstateevent handler should update the navigation token before anything else happensPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.