fix: avoid error when back navigating before page is initialized #10636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an exception when back navigating before a page is fully initialized. I believe this may also fix #10512.
I'm observing that the
popstateevent callback raises a null pointer exception when it is triggered beforecurrent.urlhas been set, resulting in the following error:From what I can follow:
When the exception is raised, the navigation code executed after scroll restoration additionally is not executed, which could be the cause of other issues mentioned in #10512
How to reproduce
I found this was easy to test in an iOS similator:
While this specific case is fairly contrived, I believe it could also be responsible for errors we are seeing as a user navigates back and forward very quickly.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.