-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: fetch doesn't respect headers from 1st arg if its type is Request #10136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ghostdevv
merged 4 commits into
sveltejs:master
from
codercms:fix/fetch-request-headers
Jun 11, 2023
Merged
fix: fetch doesn't respect headers from 1st arg if its type is Request #10136
ghostdevv
merged 4 commits into
sveltejs:master
from
codercms:fix/fetch-request-headers
Jun 11, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compatibility with libraries that call the fetch API as `fetch(new Request(...someParams))` without an `init` argument One of these libraries is https://github.com/sindresorhus/ky (https://github.com/sindresorhus/ky/blob/main/source/utils/timeout.ts)
🦋 Changeset detectedLatest commit: 7fefd9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ghostdevv
reviewed
Jun 11, 2023
Co-authored-by: Willow (GHOST) <[email protected]>
ghostdevv
approved these changes
Jun 11, 2023
Member
|
Should we have a changeset here? |
Contributor
Author
|
@ghostdevv done :) |
ghostdevv
reviewed
Jun 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compatibility with libraries that call the fetch API as
fetch(new Request(...someParams))without aninitargumentOne of these libraries is https://github.com/sindresorhus/ky (https://github.com/sindresorhus/ky/blob/main/source/utils/timeout.ts)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.