Skip to content

feat(adapter-cloudflare): expose the external ESBuild option #10110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(adapter-cloudflare): expose the external ESBuild option #10110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-peas-teach.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/adapter-cloudflare': minor
---

expose select ESBuild options as adapter options
14 changes: 14 additions & 0 deletions packages/adapter-cloudflare/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,20 @@ export interface AdapterOptions {
*/
exclude?: string[];
};
/**
* Customize a restricted set of options used by ESBuild to prepare the Cloudflare adapter bundle.
*
* @default {}
*/
esbuildOptions?: {
Copy link
Member

@benmccann benmccann Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comment here: #10424 (comment)

/**
* Mark a file or a package as external to exclude it from your build.
* Instead of being bundled, the import will be preserved and will be evaluated at run time instead.
*
* @see https://esbuild.github.io/api/#external
*/
external?: import('esbuild').BuildOptions['external'];
};
}

export interface RoutesJSONSpec {
Expand Down
1 change: 1 addition & 0 deletions packages/adapter-cloudflare/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export default function (options = {}) {

await esbuild.build({
platform: 'browser',
external: options?.esbuildOptions?.external,
conditions: ['worker', 'browser'],
sourcemap: 'linked',
target: 'es2022',
Expand Down