tsconfig contains duplicate include entries

[ebeloded]

Describe the bug

.svelte-kit/tsconfig.json "include" entry looks like this:

{
  "include": [
		"ambient.d.ts",
		"./types/**/$types.d.ts",
		"../vite.config.ts",
		"../src/**/*.js",
		"../src/**/*.ts",
		"../src/**/*.svelte",
		"../src/**/*.js", // duplicate
		"../src/**/*.ts", // duplicate
		"../src/**/*.svelte", // duplicate
		"../tests/**/*.js",
		"../tests/**/*.ts",
		"../tests/**/*.svelte"
	]
}

Reproduction

Go to https://node.new/sveltekit, open .svelte-kit/tsconfig.json

Logs

No response

System Info

-

Severity

annoyance

Additional Information

No response

[teemingc]

kit/packages/kit/src/core/sync/write_tsconfig.js

Lines 89 to 94 in fafe7d5

	for (const dir of [kit.files.routes, kit.files.lib]) {
	const relative = project_relative(path.dirname(dir));
	include.push(config_relative(`${relative}/**/*.js`));
	include.push(config_relative(`${relative}/**/*.ts`));
	include.push(config_relative(`${relative}/**/*.svelte`));
	}

This block is causing the duplicate entries. We could compare the relative output of both directories before adding them to the tsconfig.

But looking at it closer, shouldn't the output for kit.files.routes be along the lines of /src/routes/**/*.js instead of /src/**/*.js?

- "../src/**/*.js",
- "../src/**/*.ts",
- "../src/**/*.svelte",
- "../src/**/*.js", // duplicate
- "../src/**/*.ts", // duplicate
- "../src/**/*.svelte", // duplicate
+ "../src/routes/**/*.js",
+ "../src/routes/**/*.ts",
+ "../src/routes/**/*.svelte",
+ "../src/lib/**/*.js",
+ "../src/lib/**/*.ts",
+ "../src/lib/**/*.svelte",

[gtm-nayan]

Was just looking at the same thing, when the tsconfig was hardcoded in the templates, all of src was included, so can't tell if this was intended or not, and if we change it to be scoped to lib and routes now,

It might potentially be a breaking change?

[teemingc]

so can't tell if this was intended or not, and if we change it to be scoped to lib and routes now,

The default app.d.ts would also need to be moved to the directory of either kit.files.routes or kit.files.lib.

Perhaps a separate issue: currently, specifying a single folder as the path for either of those options such as config.kit.files.routes = "app" causes the output relative path to incorrectly go up 3 levels higher:

"../../../../**/*.js",
"../../../../**/*.ts",
"../../../../**/*.svelte",

[dummdidumm]

Only including sources in lib and routes would be a breaking change, yes. Looking closer at the logic, I'm wondering why we scoped it like this in the first place. Theoretically this would break if you're setting up the routes and lib folders in a weird way - but there's also no good way around this. I somewhat regret making parts of this that configurable.

Anyway, the fix would be to just deduplicate them. You could also have a closer look at the bug @s3812497 uncovered.