SvelteKit swallows parse errors

[benmccann]

Describe the bug

If vite-plugin-svelte throws a ParseError it gets swallowed by SvelteKit making it impossible to figure out what's wrong in many cases

Reproduction

Put this in +page.svelte

<script>
</script>

<script>
</script>

Logs

No response

System Info

`latest`

Severity

serious, but I can work around it

Additional Information

No response

[gtm-nayan]

The default handle error here only logs the stack, which appears to not be populated with anything at the moment.

Although I think such errors should probably be logged here instead,

I got an output like this using vite.config.logger.error, is there another utility in vite to present the error in a better way?

[dominikg]

you can send the error over devserver websocket so it gets presented to the user as an overlay.
thrown errors from plugin hooks should end up there automatically.

might need a bit of transformation to get the error to display nicely https://github.com/sveltejs/vite-plugin-svelte/blob/360171392990cd907c87b6ba16e17d7698fe9f8e/packages/vite-plugin-svelte/src/utils/error.ts#L11

[gtm-nayan]

Hmm, if the error happens while editing a loaded page, or client side navigating to a broken page there is already an overlay. The user just doesn't see anything when doing a native navigation to a page with the compiler error and the ws wouldn't be ready by then.

thrown errors from plugin hooks should end up there automatically

Turns out there was something logged before 1.0.13,

Was this logged from one of v-p-s's hooks? I think Kit calling loadSsrModule in a middleware makes the error not show up as a plugin hook error.

1.0.13 was this huge change so it's going to be fun trying to figure out what changed there to suppress V-P-S's logging. Nvm

[benmccann]

We definitely used to log the frame property. I remember adding that like a year or two ago. It looks like that was somehow lost in a refactoring. We should probably update the default handleError to use the frame and message properties when frame is present.