If `files.assets === 'public'`, Vite copies the directory's contents

[Rich-Harris]

This potentially conflicts with our own static asset handling

[benmccann]

Not sure if it's the same issue, but I saw @GrygrFlzr filed vitejs/vite#2587 about Vite's public directory as well

[jthegedus]

Hi, this issue is the cause for an annoying workflow/bug with the Firebase adapter.

The adapter reads the user's firebase.json configuration file to identify which dir contains static assets to push to the Firebase CDN, in Firebase this defaults to public and is almost never changed by the user. This results in the following process:

• svelte-kit build outputs .svelte/output/client/_app/*
• Firebase adapter then executes copy_static_files and copy_client_files which copies the static and .svelte/output/client/_app/* dir contents to public
• on subsequent svelte-kit build executions Vite then copies public contents into .svelte/output/client/_app/*, then outputs the new build as well, resulting in .svelte/output/client/_app/* and .svelte/output/client/_app/_app/*. This then gets copied by the adapter copy_static_files and copy_client_files into public.
• each re-run of svelte-kit build produces a further nested _app dir in .svelte/output/client/ resulting in increasingly large uploads to the CDN

Is it possible for my adapter to specifically disable this Vite config or should we disable it within SvelteKit, because it is causing a conflict for my use case?

[jthegedus]

The current workaround for the Firebase adapter is documentation to users to add

// package.json
"build": "npx rimraf <dir used in firebase.json:hosting.public> && svelte-kit build --verbose",

Again, the default value is public, but ideally this would be something these users didn't have to worry about.

[theodorejb]

I am also running into this issue. Is there an official workaround or fix planned?

[theodorejb]

I was able to work around this issue by setting the following in svelte.config.js:

const config = {
    // ...
    kit: {
        // ...
        vite: {
            publicDir: false,
        },
    },
};

Would it make sense for SvelteKit to set publicDir to false by default to avoid the current unexpected behavior?

[bluepuma77]

Shouldn't this be resolved in latest SvelteKit v1.0.0-next.295 from npm?

When I place static files in SvelteKit /static/public I get the following message:

files in the public directory are served at the root path.
Instead of /public/bootstrap/bootstrap.min.css, use /bootstrap/bootstrap.min.css.

I still have to manually set the vite setting and restart SvelteKit.

const config = {
  kit: {
    ...
    vite: {
      publicDir: false
    }
  }
};

Update: It seems I need to add it only for npm run dev, but with npm run build I get the message:

build_client: The value for kit.vite.publicDir specified in svelte.config.js has been ignored. This option is controlled by SvelteKit.