-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Closed
Description
Describe the problem
Now that even AWS lambda have finally got their act together and shipped Node 16 support (just in time for Node 18 to be the current LTS version), I'm not sure there's much of a reason to continue supporting Node 14?
Dropping it would simplify the test matrix slightly, and would allow us to get rid of this grotesque crypto stuff:
kit/packages/kit/src/runtime/server/page/csp.js
Lines 23 to 33 in 7609ad0
| // TODO: remove this in favor of web crypto API once we no longer support Node 14 | |
| const name = 'crypto'; // store in a variable to fool esbuild when adapters bundle kit | |
| csp_ready = import(name).then((crypto) => { | |
| generate_nonce = () => { | |
| return crypto.randomBytes(16).toString('base64'); | |
| }; | |
| generate_hash = (input) => { | |
| return crypto.createHash('sha256').update(input, 'utf-8').digest().toString('base64'); | |
| }; | |
| }); |
If Lambda supporting 16 isn't a good enough reason, then presumably we have to continue supporting 14 until it's out of LTS on April 30 next year. That doesn't seem ideal.
Describe the proposed solution
Only support Node 16 and above
Alternatives considered
No response
Importance
would make my life easier
Additional Information
No response
hyunbinseo
Metadata
Metadata
Assignees
Labels
No labels