Error: Dynamic require of "x" is not supported

[lovasoa]

Describe the bug

Upgrading to the latest version of sveltekit broke adapter-node for my application. Now the application works in development, but when packaged by adapter-node, it throws `` on start

Reproduction

It can be reproduced on lovasoa/sanipasse@79c310b

lovasoa/sanipasse@79c310b

Logs

file:///home/olojkine/dev/sanipasse/build/middlewares.js:26
  throw new Error('Dynamic require of "' + x + '" is not supported');
        ^

Error: Dynamic require of "crypto" is not supported
    at __require (file:///home/olojkine/dev/sanipasse/build/middlewares.js:26:9)
    at node_modules/@peculiar/webcrypto/build/webcrypto.js (file:///home/olojkine/dev/sanipasse/build/middlewares.js:8119:19)
    at __require2 (file:///home/olojkine/dev/sanipasse/build/middlewares.js:32:44)
    at node_modules/isomorphic-webcrypto/src/index.js (file:///home/olojkine/dev/sanipasse/build/middlewares.js:10253:22)
    at __require2 (file:///home/olojkine/dev/sanipasse/build/middlewares.js:32:44)
    at node_modules/isomorphic-webcrypto/src/main.js (file:///home/olojkine/dev/sanipasse/build/middlewares.js:10262:22)
    at __require2 (file:///home/olojkine/dev/sanipasse/build/middlewares.js:32:44)
    at file:///home/olojkine/dev/sanipasse/build/middlewares.js:10271:46
    at ModuleJob.run (node:internal/modules/esm/module_job:183:25)
    at async Loader.import (node:internal/modules/esm/loader:178:24)

System Info

System:
    OS: Linux 5.13 Fedora 34 (Workstation Edition) 34 (Workstation Edition)
    CPU: (8) x64 Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
    Memory: 2.64 GB / 15.28 GB
    Container: Yes
    Shell: 5.1.0 - /bin/bash
  Binaries:
    Node: 16.5.0 - /usr/bin/node
    Yarn: 1.22.10 - /usr/bin/yarn
    npm: 7.19.1 - /usr/bin/npm
  Browsers:
    Firefox: 91.0.2
  npmPackages:
    @sveltejs/adapter-node: next => 1.0.0-next.46 
    @sveltejs/adapter-static: next => 1.0.0-next.18 
    @sveltejs/kit: next => 1.0.0-next.165 
    svelte: ^3.38.3 => 3.42.5 

Severity

blocking all usage of SvelteKit

Additional Information

No response

[lovasoa]

If I manually change the generated build/middlewares.js to add global.require = createRequire(import.meta.url); at the top, the app starts normally

[quentincaffeino]

Also got this issue but with another package.

@lovasoa how about renaming title to Error: Dynamic require of "x" is not supported since it doesn't really depend on which package you are importing? For me this happened with package tty, which was imported by supports_color package.

I updated each package separately in my project to find the cause of the issue and interestingly this is caused by eslint-plugin-svelte3 version 3.2.1. Works on version 3.2.0. @lovasoa also has his package updated in lock file.

[dummdidumm]

That's very strange, from 3.2.0 to 3.21 there shouldn't be a difference related to dynamic requires.

[quentincaffeino]

Also wonder how this happens, but I know nothing of svelte sources so...

This is require function before:

var __require = (x) => {
  if (typeof require !== "undefined")
    return require(x);
  throw new Error('Dynamic require of "' + x + '" is not supported');
};

and after updating eslint-plugin-svelte3:

var __require = typeof require !== "undefined" ? require : (x) => {
  throw new Error('Dynamic require of "' + x + '" is not supported');
};

Problem could be within immediate condition execution but I'm not sure how.

[lovasoa]

I tried to update all the dependencies and just pin eslint-plugin-svelte3@3.2.0, and the problem is still present, so this is probably not where the bug is.

[lovasoa]

Manually resetting the old definition of __require in middlewares.js does prevent the error from occurring. The global require is undefined when __require is defined at the top of the file, but is then dynamically added by the init_shims calls.

[dummdidumm]

This sounds like some bundler (esbuild?) changed the transpilation (the __require thing) which does not account for a dynamically added require. Question is if the init_shims can somehow be moved above it.

[lovasoa]

I made a PR to esbuild to revert the change. See my comment there.

[Conduitry]

I've commented on that PR with more SvelteKit context to help esbuild maintainers understand why we need this.

I've also found evanw/esbuild#946 which appears to be the main issue for why we needed this shim in the first place. I haven't checked whether the other suggested workarounds in that issue (like the banner one, for example) will still help us here even with the change to __require.

[lovasoa]

Maybe the quick fix here in svelte is to publish a release that uses banner, to prevent more people updating their dependencies from breaking their project ?

This is quite an annoying bug, because there is no obvious way to know where it comes from for the end user, who may spend a lot of time looking for a bug in their own code.

[Conduitry]

evanw/esbuild#1604 (comment) It sounds like this won't be fixed/supported soon on the esbuild side. We probably should look into a banner solution or, failing that, a hacky manual editing of the bundled file after esbuild outputs it.