% cannot be escaped in url params #1746
Description
Describe the bug
parameterized routes do not properly parse the % sign in a url.
If I have a url that contains a percent that needs to be escaped, I would use the function encodeUri. For example:
encodeURI('/sample/test%20me') // returns "/sample/test%2520me"What actually happens, is svelte kit reads this url as test me
Logs
To Reproduce
npm init svelte@next
npm installcreate the file src/routes/sample/[param].svelte with the following contents:
<script context="module">
export function load({ page }) {
const { param } = page.params
return {
props: { param }
}
}
</script>
<script>
export let param
</script>
param is: "{param}"opening this url: http://localhost:3000/sample/test%2520me displays param is "test me"
Expected behavior
the page should display param is test%20me.
Stacktraces
Information about your SvelteKit Installation:
Diagnostics
System: OS: Linux 5.12 Arch Linux CPU: (4) x64 Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz Memory: 5.48 GB / 18.96 GB Container: Yes Shell: 5.8 - /usr/bin/zsh Binaries: Node: 16.3.0 - /usr/local/bin/node Yarn: 1.22.4 - ~/.npm-packages/bin/yarn npm: 7.11.2 - ~/.npm-packages/bin/npm Browsers: Firefox: 89.0.1 npmPackages: @sveltejs/kit: next => 1.0.0-next.116 svelte: ^3.34.0 => 3.38.3- Your browser:
Google Chrome 91.0.4472.114
Severity
I have a local web app that displays system files using a route like src/routes/file/[...filepath].svelte. For whatever reason, some files happen to contain %20 inside them (likely because they were encoded weirdly once upon a time. With this bug as it stands, I cannot display any files that contain percents inside them, because I have no way of telling the server that a percent is part of the filepath.
Additional context
I found a possibly related issue in the polka server repo: lukeed/polka#119 (I assume polka is still the internal server)