Skip to content

fix(no-navigation-without-resolve): improve error messages #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

fix(no-navigation-without-resolve): improve error messages #1377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tame-walls-sleep.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'eslint-plugin-svelte': patch
---

fix(no-navigation-without-resolve): improve error messages
8 changes: 4 additions & 4 deletions packages/eslint-plugin-svelte/src/rules/no-navigation-without-resolve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ export default createRule('no-navigation-without-resolve', {
}
],
messages: {
gotoWithoutResolve: "Found a goto() call with a url that isn't resolved.",
linkWithoutResolve: "Found a link with a url that isn't resolved.",
pushStateWithoutResolve: "Found a pushState() call with a url that isn't resolved.",
replaceStateWithoutResolve: "Found a replaceState() call with a url that isn't resolved."
gotoWithoutResolve: 'Unexpected goto() call without resolve().',
linkWithoutResolve: 'Unexpected href link without resolve().',
pushStateWithoutResolve: 'Unexpected pushState() call without resolve().',
replaceStateWithoutResolve: 'Unexpected replaceState() call without resolve().'
},
type: 'suggestion',
conditions: [
Expand Down
2 changes: 1 addition & 1 deletion ...lte/tests/fixtures/rules/no-navigation-without-resolve/invalid/goto-aliased01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- message: Found a goto() call with a url that isn't resolved.
- message: Unexpected goto() call without resolve().
line: 4
column: 8
suggestions: null
2 changes: 1 addition & 1 deletion .../fixtures/rules/no-navigation-without-resolve/invalid/goto-namespace-import01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- message: Found a goto() call with a url that isn't resolved.
- message: Unexpected goto() call without resolve().
line: 4
column: 18
suggestions: null
4 changes: 2 additions & 2 deletions ...s/fixtures/rules/no-navigation-without-resolve/invalid/goto-partial-resolve01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
- message: Found a goto() call with a url that isn't resolved.
- message: Unexpected goto() call without resolve().
line: 5
column: 7
suggestions: null
- message: Found a goto() call with a url that isn't resolved.
- message: Unexpected goto() call without resolve().
line: 6
column: 7
suggestions: null
4 changes: 2 additions & 2 deletions ...s/fixtures/rules/no-navigation-without-resolve/invalid/goto-without-resolve01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
- message: Found a goto() call with a url that isn't resolved.
- message: Unexpected goto() call without resolve().
line: 6
column: 7
suggestions: null
- message: Found a goto() call with a url that isn't resolved.
- message: Unexpected goto() call without resolve().
line: 7
column: 7
suggestions: null
6 changes: 3 additions & 3 deletions ...s/fixtures/rules/no-navigation-without-resolve/invalid/link-partial-resolve01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 7
column: 9
suggestions: null
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 8
column: 9
suggestions: null
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 9
column: 9
suggestions: null
10 changes: 5 additions & 5 deletions ...sts/fixtures/rules/no-navigation-without-resolve/invalid/link-with-fragment01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 5
column: 10
suggestions: null
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 6
column: 9
suggestions: null
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 7
column: 9
suggestions: null
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 8
column: 9
suggestions: null
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 9
column: 9
suggestions: null
10 changes: 5 additions & 5 deletions ...s/fixtures/rules/no-navigation-without-resolve/invalid/link-without-resolve01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 5
column: 10
suggestions: null
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 6
column: 9
suggestions: null
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 7
column: 9
suggestions: null
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 8
column: 9
suggestions: null
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 9
column: 9
suggestions: null
2 changes: 1 addition & 1 deletion ...ests/fixtures/rules/no-navigation-without-resolve/invalid/pushState-aliased01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- message: Found a pushState() call with a url that isn't resolved.
- message: Unexpected pushState() call without resolve().
line: 4
column: 8
suggestions: null
2 changes: 1 addition & 1 deletion ...ures/rules/no-navigation-without-resolve/invalid/pushState-namespace-import01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- message: Found a pushState() call with a url that isn't resolved.
- message: Unexpected pushState() call without resolve().
line: 4
column: 23
suggestions: null
4 changes: 2 additions & 2 deletions ...tures/rules/no-navigation-without-resolve/invalid/pushState-partial-resolve01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
- message: Found a pushState() call with a url that isn't resolved.
- message: Unexpected pushState() call without resolve().
line: 5
column: 12
suggestions: null
- message: Found a pushState() call with a url that isn't resolved.
- message: Unexpected pushState() call without resolve().
line: 6
column: 12
suggestions: null
4 changes: 2 additions & 2 deletions ...tures/rules/no-navigation-without-resolve/invalid/pushState-without-resolve01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
- message: Found a pushState() call with a url that isn't resolved.
- message: Unexpected pushState() call without resolve().
line: 6
column: 12
suggestions: null
- message: Found a pushState() call with a url that isn't resolved.
- message: Unexpected pushState() call without resolve().
line: 7
column: 12
suggestions: null
2 changes: 1 addition & 1 deletion ...e/tests/fixtures/rules/no-navigation-without-resolve/invalid/recursive-loop01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- message: Found a link with a url that isn't resolved.
- message: Unexpected href link without resolve().
line: 6
column: 9
suggestions: null
2 changes: 1 addition & 1 deletion ...s/fixtures/rules/no-navigation-without-resolve/invalid/replaceState-aliased01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- message: Found a replaceState() call with a url that isn't resolved.
- message: Unexpected replaceState() call without resolve().
line: 4
column: 8
suggestions: null
2 changes: 1 addition & 1 deletion ...s/rules/no-navigation-without-resolve/invalid/replaceState-namespace-import01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- message: Found a replaceState() call with a url that isn't resolved.
- message: Unexpected replaceState() call without resolve().
line: 4
column: 26
suggestions: null
4 changes: 2 additions & 2 deletions ...es/rules/no-navigation-without-resolve/invalid/replaceState-partial-resolve01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
- message: Found a replaceState() call with a url that isn't resolved.
- message: Unexpected replaceState() call without resolve().
line: 5
column: 15
suggestions: null
- message: Found a replaceState() call with a url that isn't resolved.
- message: Unexpected replaceState() call without resolve().
line: 6
column: 15
suggestions: null
4 changes: 2 additions & 2 deletions ...es/rules/no-navigation-without-resolve/invalid/replaceState-without-resolve01-errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
- message: Found a replaceState() call with a url that isn't resolved.
- message: Unexpected replaceState() call without resolve().
line: 6
column: 15
suggestions: null
- message: Found a replaceState() call with a url that isn't resolved.
- message: Unexpected replaceState() call without resolve().
line: 7
column: 15
suggestions: null
Loading