feat(no-navigation-without-resolve): checking link shorthand attributes

[marekdedic]

Fixes the issue mentioned in #1319 (comment)

But this is too interconnected with #1322, @ota-meshi can we get that one merged first please and I will then rebase this one :)

[changeset-bot]

🦋 Changeset detected

Latest commit: 70a5aac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-svelte	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@70a5aac

Published Instant Preview Packages:

• eslint-plugin-svelte: https://pkg.pr.new/eslint-plugin-svelte@70a5aac

View Commit

[marekdedic]

This one is now ready :)

[baseballyama]

Why does it only check href? Shouldn’t the following patterns also be checked?

<script>
  const validLink = resolve("/foo");
  const invalidLink = "/foo";
</script>
<a href={validLink}>Click me!</a>
<a href={invalidLink}>Click me!</a>

[marekdedic]

Those are already checked without this PR :) This one just adds support for the shorthand...

[ota-meshi]

Could you extract this outside of the return {...} and store it in a variable?
This will prevent us from having to modify the default option in multiple places in the future and forgetting to do so.