Skip to content

Conversation

benmccann
Copy link
Member

matches the language used in the announcement blog post

closes #82

Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: c77cf93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Oct 25, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@226

commit: c77cf93

@manuel3108
Copy link
Member

Is there a reason you decided to go with add-ons instead of addons? Probably from the blog post I imagine. Googeling around a bit it looks like both things are commonly used and i was unable to find any preference for one thing.

I noticed this while looking at the new args and --no-add-ons feels wired to me.

Also this PR "only" covers the public facing stuff. We should think about renaming our currently internal stuff to addons as well and potentially create a follow up. Especially in regard to the public facing API i think stuff like defineAdderOptions and defineAdder do not make much sense.

@Rich-Harris
Copy link
Member

Add-on is correct!

--no-add-ons feels wired to me

We already use hyphenated flags elsewhere (--compiler-warnings, --diagnostic-sources etc) so I think it's fine to have another. (Though we do also have --preserveWatchOutput which should be updated to match the conventions everywhere else)

@benmccann
Copy link
Member Author

benmccann commented Oct 28, 2024

--compiler-warnings, etc. are replacing a space with a hyphen, which makes sense. I guess the question is if you start out with a hyphen, do you just remove it or leave it as a hyphen? I'm not opposed to having --no-addons as compared to --no-add-ons. Though maybe --no-add-ons looks nicer to me. But I agree that everywhere in text I would leave it as "Add-on", which is much more commonly used

@Rich-Harris Rich-Harris mentioned this pull request Oct 30, 2024
@Rich-Harris Rich-Harris merged commit 94cbf38 into main Oct 30, 2024
5 checks passed
@Rich-Harris Rich-Harris deleted the add-ons branch October 30, 2024 22:14
@Rich-Harris
Copy link
Member

great news, merging this caused sveltejs/svelte.dev#729 to update. PRs will now automatically be created whenever docs changes are merged to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename 'adders' to add-ons
3 participants