Skip to content

feat: adds util function to get available first factors #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feat/plugin/experiment
Choose a base branch
from

Conversation

namsnath
Copy link
Contributor

@namsnath namsnath commented Aug 7, 2025

  • Moves is_recipe_initialized to supertokens.asyncio
  • Cleans up supertokens init file to reduce redundancy
  • Adds test to ensure FactorIds class and method are in sync

ref: supertokens/supertokens-node#1021

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Item1
  • Item2

- Moves is_recipe_initialized to supertokens.asyncio
- Cleans up supertokens __init__ file to reduce redundancy
- Adds test to ensure FactorIds class and method are in sync

ref: supertokens/supertokens-node#1021
@namsnath namsnath self-assigned this Aug 7, 2025
Comment on lines +8 to +10
if (
(not k.startswith("__") or not k.endswith("__"))
and not k.startswith("<")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic for filtering out dunder methods is incorrect. The current condition (not k.startswith("__") or not k.endswith("__")) will actually include dunder methods because it only requires one of the conditions to be true. To properly exclude dunder methods, use and instead:

(not k.startswith("__") and not k.endswith("__"))

This ensures both conditions must be true for a method to be included in the list.

Suggested change
if (
(not k.startswith("__") or not k.endswith("__"))
and not k.startswith("<")
if (
(not k.startswith("__") and not k.endswith("__"))
and not k.startswith("<")

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@namsnath namsnath requested review from sattvikc and porcellus August 11, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant