Skip to content

fix: thirdparty info for dashboard #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [0.29.1] - 2025-04-11
- Fixes an issue where `removeDevice` API allowed removing TOTP devices without the user completing MFA.
- Fixes issue with ThirdParty provider info on dashboard

## [0.29.0] - 2025-03-03
### Breaking changes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,23 +114,28 @@ async def get_third_party_config(

# query param may be passed if we are creating a new third party config, check and update accordingly

if third_party_id in ["okta", "active-directory", "boxy-saml", "google-workspaces"]:
if third_party_id == "okta":
if any(
[
third_party_id.startswith(tp_id)
for tp_id in ["okta", "active-directory", "boxy-saml", "google-workspaces"]
]
):
if third_party_id.startswith("okta"):
okta_domain = options.request.get_query_param("oktaDomain")
if okta_domain is not None:
additional_config = {"oktaDomain": okta_domain}
elif third_party_id == "active-directory":
elif third_party_id.startswith("active-directory"):
directory_id = options.request.get_query_param("directoryId")
if directory_id is not None:
additional_config = {"directoryId": directory_id}
elif third_party_id == "boxy-saml":
elif third_party_id.startswith("boxy-saml"):
boxy_url = options.request.get_query_param("boxyUrl")
boxy_api_key = options.request.get_query_param("boxyAPIKey")
if boxy_url is not None:
additional_config = {"boxyURL": boxy_url}
if boxy_api_key is not None:
additional_config["boxyAPIKey"] = boxy_api_key
elif third_party_id == "google-workspaces":
elif third_party_id.startswith("google-workspaces"):
hd = options.request.get_query_param("hd")
if hd is not None:
additional_config = {"hd": hd}
Expand Down
Loading