AdGeneration: Align first-party data example with OpenRTB spec (id必須, valueは非必須) #4
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the AdGeneration bidder documentation to align the first-party data example with the OpenRTB specification. The OpenRTB specification requires the `id` field for objects within the `user.data[].segment` array. However, the code example in the AdGeneration bidder documentation was incorrectly using the `name` field. This discrepancy causes valid first-party data to be filtered out by the `validationFpdModule`, as it correctly enforces the OpenRTB standard by rejecting segments that lack the required `id` field. - In `dev-docs/bidders/adgeneration.md`, the `firstpartydata` example has been updated. - The `name` key in the `segment` objects has been replaced with `id`. This change ensures the documentation provides a correct, compliant example for publishers, preventing potential integration issues.
ss-toshihide-tajima
changed the title
8 tasks
Collaborator
Author
|
related PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the AdGeneration bidder documentation to align the first-party data example with the OpenRTB specification. The OpenRTB specification requires the
idfield for objects within theuser.data[].segmentarray. However, the code example in the AdGeneration bidder documentation was incorrectly using thenamefield. This discrepancy causes valid first-party data to be filtered out by thevalidationFpdModule, as it correctly enforces the OpenRTB standard by rejecting segments that lack the requiredidfield.dev-docs/bidders/adgeneration.md, thefirstpartydataexample has been updated.namekey in thesegmentobjects has been replaced withid. This change ensures the documentation provides a correct, compliant example for publishers, preventing potential integration issues.🏷 Type of documentation
📋 Checklist