Skip to content

fix(auth): auth event emitter being shared among clients #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix(auth): auth event emitter being shared among clients #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/Auth/Internal/CodeVerifierStorage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ struct CodeVerifierStorage: Sendable {
}

extension CodeVerifierStorage {
static let live: Self = {
static var live: Self {
let code = LockIsolated(String?.none)

return Self(
get: { code.value },
set: { code.setValue($0) }
)
}()
}
}
2 changes: 1 addition & 1 deletion Sources/Auth/Internal/Dependencies.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ struct Dependencies: Sendable {
var sessionStorage: SessionStorage
var sessionManager: SessionManager

var eventEmitter: AuthStateChangeEventEmitter = .shared
var eventEmitter = AuthStateChangeEventEmitter()
var date: @Sendable () -> Date = { Date() }
var codeVerifierStorage = CodeVerifierStorage.live
var urlOpener: URLOpener = .live
Expand Down
4 changes: 1 addition & 3 deletions Sources/Auth/Internal/EventEmitter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ import Foundation
import Helpers

struct AuthStateChangeEventEmitter {
static let shared = AuthStateChangeEventEmitter(emitter: .init(initialEvent: nil, emitsLastEventWhenAttaching: false))

let emitter: EventEmitter<(AuthChangeEvent, Session?)?>
var emitter = EventEmitter<(AuthChangeEvent, Session?)?>(initialEvent: nil, emitsLastEventWhenAttaching: false)

func attach(_ listener: @escaping AuthStateChangeListener) -> ObservationToken {
emitter.attach { event in
Expand Down
Loading