Skip to content

fix: Use class methods instead of bound arrow functions for rest calls #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: Use class methods instead of bound arrow functions for rest calls #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions src/SupabaseClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export default class SupabaseClient<
*
* @param relation - The table or view name to query
*/
from: PostgrestClient<Database, SchemaName>['from'] = (relation: string) => {
from(relation: string) {
return this.rest.from(relation)
}

Expand All @@ -142,11 +142,7 @@ export default class SupabaseClient<
*
* @param schema - The name of the schema to query
*/
schema: PostgrestClient<Database, SchemaName>['schema'] = <
DynamicSchema extends string & keyof Database
>(
schema: DynamicSchema
) => {
schema<DynamicSchema extends string & keyof Database>(schema: DynamicSchema) {
return this.rest.schema<DynamicSchema>(schema)
}

Expand All @@ -171,17 +167,14 @@ export default class SupabaseClient<
* `"estimated"`: Uses exact count for low numbers and planned count for high
* numbers.
*/
rpc: PostgrestClient<Database, SchemaName>['rpc'] = <
FunctionName extends string & keyof Schema['Functions'],
Function_ extends Schema['Functions'][FunctionName]
>(
fn: FunctionName,
args: Function_['Args'] = {},
rpc<FnName extends string & keyof Schema['Functions'], Fn extends Schema['Functions'][FnName]>(
fn: FnName,
args: Fn['Args'] = {},
options?: {
head?: boolean
count?: 'exact' | 'planned' | 'estimated'
}
) => {
) {
return this.rest.rpc(fn, args, options)
}

Expand Down