-
-
Couldn't load subscription status.
- Fork 266
feat(postgrest): updates for postgREST 11 #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
With the update to postgREST v11 the test |
|
Thanks for this! I am a bit swamped today, but will take a look tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is spotless as usual 🚀 Just the one thing about the default value for defaultToNull parameter gets me. I have left a comment here, so let's see what the js team says.
https://github.com/supabase/postgrest-js/pull/417/files#r1268195130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great! Feel free to edit the comments to whatever you think best communicates the behavior to the users!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, could you check why the tests might be failing? It seems like it has nothing to do with any of the changes in this PR though.
|
@dshukertjr See #550 (comment) above for the test failing. With postgrest 9 or 10 it works, but 11 doesn't. |
|
@Vinzent03 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the amazing work!
Changes
anyandallversion tolikeandilikedefaultToNullto use default value instead of null for missing value in bulk insert/upsertRessources