chore: require app_links ^6.2.0 #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grdsdev
approved these changes
Sep 30, 2025
Pull Request Test Coverage Report for Build 18130545220Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Upgrade app_links
What is the current behavior?
We allow a wide range of app_links version, because we didn't want to introduce a breaking change. The methods had changed though so we supported both versions by using a try catch. This causes issues with using a debugger which stops even at caught exceptions.
What is the new behavior?
v6.0 got released in May 2024, so I think it is fine now to require the latest version.
Additional context
close #1124
#941
close #1205