feat: vector buckets #774
Merged
feat: vector buckets #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⛔ Snyk checks have failed. 8 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![snyk-io[bot]](https://avatars.githubusercontent.com/in/372950?s=60&v=4){kind=small}
fenos
force-pushed
the
feat/vector-buckets
branch
6 times, most recently
from
01797cc to
a2715e7
Compare
Pull Request Test Coverage Report for Build 19099986462Details
💛 - Coveralls |
itslenny
requested changes
Oct 10, 2025
fenos
force-pushed
the
feat/vector-buckets
branch
from
a2715e7 to
6bf5f59
Compare
fenos
force-pushed
the
feat/vector-buckets
branch
from
6bf5f59 to
f2ae953
Compare
fenos
force-pushed
the
feat/vector-buckets
branch
9 times, most recently
from
2059ee5 to
2e888a1
Compare
inian
approved these changes
Nov 5, 2025
fenos
force-pushed
the
feat/vector-buckets
branch
2 times, most recently
from
b7a491e to
528b466
Compare
fenos
force-pushed
the
feat/vector-buckets
branch
from
528b466 to
cf989fd
Compare
fenos
force-pushed
the
feat/vector-buckets
branch
from
cf989fd to
a879634
Compare
itslenny
approved these changes
Nov 5, 2025
| }, | ||
| // allow arbitrary additional args specific to the requirement | ||
| ref: { type: 'string' }, | ||
| // 'snapshot-id': { type: 'number', format: 'int64', bigint: true }, |
There was a problem hiding this comment.
Will this be added/uncommented in the future? Otherwise remove this line.
| // format: 'int64', | ||
| // bigint: true, | ||
| // nullable: true, | ||
| // }, |
| try { | ||
| if (typeof payload === 'string') return done(null, JSONBigint.parse(payload)) | ||
| if (Buffer.isBuffer(payload)) return done(null, JSONBigint.parse(payload.toString('utf8'))) | ||
| if (payload && typeof (payload as any).on === 'function') { |
There was a problem hiding this comment.
This check is kinda icky... maybe replace with a type guard
function isReadableStream(obj: unknown): obj is NodeJS.ReadableStream {
return (
obj != null &&
typeof obj === 'object' &&
typeof (obj as NodeJS.ReadableStream).on === 'function'
)
}Then you can do this and remove the as NodeJS.ReadableStream
if (isReadableStream(payload)) {
// ...
}| getConfig() | ||
|
|
||
| // Sharding for special buckets (vectors, analytics) | ||
| const sharding = new ShardCatalog(new KnexShardStoreFactory(multitenantKnex)) |
There was a problem hiding this comment.
should this be inside the isMultitenant if block?
| // headers: response.request.headers, | ||
| // }) | ||
| return response.data | ||
| }) |
| // req.data ? ` \\\n -d '${JSON.stringify(req.data)}'` : '' | ||
| // } | ||
| // `.trim() | ||
| // ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the new behaviour?
Implement Vector Bucket data source
Supported Operations:
Authentication mechanisms:
Sharding
Analytics Buckets